Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF format + random changes #77

Merged
merged 5 commits into from
Mar 14, 2024
Merged

PDF format + random changes #77

merged 5 commits into from
Mar 14, 2024

Conversation

zoyagarg
Copy link
Contributor

Fixing the PDF

♻️ Current situation & Problem

  • Include social history when appropriate
  • Reformat so it looks professional (all left, secondary colors)
  • Fix length issues
  • Reformat patient responses

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 5.87%. Comparing base (ff294b3) to head (c1df641).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main     #77      +/-   ##
========================================
- Coverage   5.92%   5.87%   -0.05%     
========================================
  Files         62      62              
  Lines       3598    3632      +34     
========================================
  Hits         213     213              
- Misses      3385    3419      +34     
Files Coverage Δ
Intake/ScrollablePDF.swift 0.00% <0.00%> (ø)
Intake/SocialHistory/MenstrualHistory.swift 0.00% <0.00%> (ø)
Intake/Export/ExportView.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff294b3...c1df641. Read the comment docs.

Copy link
Contributor

@apgupta3303 apgupta3303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@zoyagarg zoyagarg merged commit 14e0ee7 into main Mar 14, 2024
7 checks passed
@zoyagarg zoyagarg deleted the pdfFormat branch March 14, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants